Skip to content

Suppress Docker build output when --quiet flag is set#521

Merged
ianpittwood merged 1 commit into
mainfrom
suppress-docker-output-on-quiet
May 12, 2026
Merged

Suppress Docker build output when --quiet flag is set#521
ianpittwood merged 1 commit into
mainfrom
suppress-docker-output-on-quiet

Conversation

@ianpittwood

@ianpittwood ianpittwood commented May 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Pass progress=False to docker.build and docker.buildx.bake when SETTINGS.log_level >= logging.ERROR (i.e. the user passed --quiet), otherwise use progress="auto".
  • Update the affected assert_called_once_with(**expected_build_args) test expectations in test_image_target.py and test_bake.py to include the new progress kwarg.

Test plan

  • uv run pytest -m build test/image/test_image_target.py test/image/bake/test_bake.py passes (15/15).
  • Manual: run bakery build --quiet ... and confirm buildx progress output is suppressed.
  • Manual: run bakery build ... (default) and bakery build --verbose ... and confirm progress output is unchanged.

🤖 Generated with Claude Code

Pass `progress=False` to `docker.build` and `docker.buildx.bake` when
the configured log level is `ERROR` or higher, so buildx progress output
is captured instead of streamed to stderr. The default and `--verbose`
log levels continue to use `progress="auto"`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@ianpittwood ianpittwood requested a review from bschwedler as a code owner May 11, 2026 19:50
@github-actions

Copy link
Copy Markdown

Test Results

1 539 tests  ±0   1 539 ✅ ±0   8m 45s ⏱️ +44s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit ed765d8. ± Comparison against base commit 8e48d8e.

@bschwedler bschwedler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change.

Though running bakery build --quiet now feels a little too quiet. 😀

@ianpittwood

Copy link
Copy Markdown
Contributor Author

Thanks for making this change.

Though running bakery build --quiet now feels a little too quiet. 😀

Haha we could always add a little spinner in the future, but at least the behavior is as intended now.

@ianpittwood ianpittwood added this pull request to the merge queue May 12, 2026
Merged via the queue into main with commit ece0519 May 12, 2026
23 checks passed
@ianpittwood ianpittwood deleted the suppress-docker-output-on-quiet branch May 12, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants